[ENH] V1 → V2 API Migration - estimation procedures#1604
[ENH] V1 → V2 API Migration - estimation procedures#1604EmanAbdelhaleem wants to merge 82 commits intoopenml:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
+ Coverage 52.04% 53.86% +1.82%
==========================================
Files 36 63 +27
Lines 4333 5044 +711
==========================================
+ Hits 2255 2717 +462
- Misses 2078 2327 +249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #...
Depends on #1576
Related to #1575
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
Can you please take a look at the function _get_estimation_procedure_list in tasks/functions and see if it can also be replaced via the list method or a new method in EstimationProcedures class?
EmanAbdelhaleem
force-pushed
the
estimation-procedures-mig
branch
from
2f6aa34 to
94d1163
Compare
This reverts commit fd43c48.
EmanAbdelhaleem
force-pushed
the
estimation-procedures-mig
branch
from
f8c4791 to
0d9868a
Compare
|
@geetu040 Ready for review |
- removing this since it was not part of the sdk previously - some tests fail because of the timeout in stacked PRs - this option can easily be added if needed in future
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
looks good, let's see if we need to change anything after discussion concludes on design
5 participants
Fixes #1622
Depends on #1576
Related to: #1575
Details
This PR implements
EstimationProceduresresource, and refactor its existing functions